search

stevenvachon / winattr

Foolproof Windows® file attributes.
MIT License
24 stars 6 forks source link

Slow to parse #2

Closed calebcbaker closed 7 years ago

calebcbaker commented 7 years ago

Getting properties of a single file/folder can take 1/2 second, if looping over multiple files this can really add up.

stevenvachon commented 7 years ago

What version of Node?

calebcbaker commented 7 years ago

Node: 6.3.1 Electron: 1.6.2 OS: Win7 and Win10

stevenvachon commented 7 years ago

If it's taking a half second per file, then it must be using the command line fallback. I haven't tested this with Electron, but that could be causing the binding to fail.

stevenvachon commented 7 years ago

Ah, it will be fixed when Node 8.x is released.

calebcbaker commented 7 years ago

Yeah after some digging around I found the fallback, and can verify that is being used. I thinking my next steps are to just use fswin directly but rebuild it to work with electron.

stevenvachon commented 7 years ago

Sounds like a lot of work for something that still currently works, albeit slow, and will be fixed for you within a couple of weeks.