search

stevenwanderski / bxslider-4

Responsive jQuery content slider
Other
4.22k stars 1.85k forks source link

reloadSlider() destroys and doesn't replace custom pages elements #464

Open justinthrelkeld opened 10 years ago

justinthrelkeld commented 10 years ago

In the case of setting pagerCustom, reloading the slider via reloadSlider() removes the pager element, but doesn't replace it.

When pagerCustom is set, the slider should simply ignore the pager element if possible, as it exists in the DOM before the slider is initialized.

sinisavukovic commented 10 years ago

Hi! I had the same problem. On line 1294 replace: if(slider.pagerEl) slider.pagerEl.remove(); with : if (slider.settings.pagerCustom === '') { if(slider.pagerEl) slider.pagerEl.remove(); }

More info here