search

stevenwanderski / bxslider-4

Responsive jQuery content slider
Other
4.22k stars 1.85k forks source link

destroySlider removes thumbnails from DOM #690

Open JohnnyT74 opened 9 years ago

JohnnyT74 commented 9 years ago

Hi, you have an amazing plugin here but I'm finding that if I delete a slide via jquery and then reload the slider via reloadSlider then the thumbnails disappear.

This is because on line 1298 (of v4.1.1) you have if(slider.pagerEl) slider.pagerEl.remove();

This is removing that div from the DOM. This destroySlider also gets called when the slider is 'reloaded'

You could pass something to the function if you were 'reloading' the slider to not remove from the DOM the whole div (or put it back afterwards)?

Keep up the great work

Cheers

John :-)

amit-brainstormforce commented 8 years ago

We are getting similar issue. I hope BXSlider will look into this as soon as possible.

JohnnyT74 commented 8 years ago

I wouldn't hold your breath. I posted that nearly a year ago! :-)