search

stevenwanderski / bxslider-4

Responsive jQuery content slider
Other
4.22k stars 1.85k forks source link

autoslide when window not flagged as "active" #885

Open Insomnia88 opened 9 years ago

Insomnia88 commented 9 years ago

I don't know if it's supposed to be a feature or a bug but the slider does stop the autoslide when the window is not active. For example if I minify it, switch to another tab or go to a window on another monitor. This behaviour doesn't occur in the examples at the project website (4.1.2 is used there). If it is supposed to be a feature then I would be glad to make an option for this "mode" so people can deactivate it if they want to.

satetsu888 commented 9 years ago

I found this too. It occurs only if auto: true and autoDelay: 0 (default) was set.

Below code commited in ec4a9b1efcf1ab for #702 seems to cause this. https://github.com/stevenwanderski/bxslider-4/blob/master/src/js/jquery.bxslider.js#L908-L913

So, this may be a feature, but undocumented and no option. I agree to make an option for this, like autoWhenActive.

Can I make pull request for this ?

Insomnia88 commented 9 years ago

Sure :P When it really solves the issue.