search

steveny2k / docker-predictionio

Docker container for PredictionIO-based machine learning services
73 stars 57 forks source link

SBT patch #1

Closed davescruggs closed 7 years ago

davescruggs commented 7 years ago

Hi, Steven:

Lines through 37 are important--it's the scala and sbt install.

Lines 57 -> EOF are where I was trying to get Tapster to install as part of the image creation. That wasn't working (and I spent too much time on that). That original code will work when pasted into bash, but docker build is using "/bin/sh", so it gets caught on "source" and on bundle.

steveny2k commented 7 years ago

@davescruggs Thanks a lot for pull-request. Sorry I did not notice this PR until now. Would like to discuss with you on the necessity of installing Scala related components, which is trade-off between more features vs size. I am thinking that if most potential projects used by PIO would need Scala, then it is necessary. Let me know your opinion. Thanks, Steven

steveny2k commented 7 years ago

have not heard back from the assignee. closing it now. can reopen later.