search

stevenygd / PointFlow

PointFlow : 3D Point Cloud Generation with Continuous Normalizing Flows
https://www.guandaoyang.com/PointFlow/
MIT License
720 stars 101 forks source link

Why is the opt step inside the forward pass? #10

Closed VictorZuanazzi closed 4 years ago

VictorZuanazzi commented 4 years ago

https://github.com/stevenygd/PointFlow/blob/e15a9ccd030990e25df64ecd583680d2c7d0f3c9/models/networks.py#L168

Congrats for the work. I was just wondering if there is a reason for the opt.step() to be inside the forward pass of the PointFlow. Is that necessary?

stevenygd commented 4 years ago

Nope, that's just the artifact of naming .