search

steveohara / j2mod

Enhanced Modbus library implemented in the Java programming language
Apache License 2.0
267 stars 111 forks source link

Added unit tests for some classes. #13

Closed martentamerius closed 8 years ago

martentamerius commented 8 years ago

Unit tests (some more important than others... ;-) for a few classes.

steveohara commented 8 years ago

Excellent, thanks Marten.

To answer your previous question about ReadWriteMultipleRegisters

You can use function 23 in the traditional manner i.e. use the request as per the AbstractTestModbusTestMaster.readRequest - create a Transport, Request, Transaction and Response. This is how it was always done in the original jamod and AbstractModbusMaster is really just a wrapper around those calls.

I think the intention of the Facade package was to provide a very simple way to use the library for the majority of cases. The implementation was extremely poor so I can only think that it was an afterthought of the original developers, more a way to test the interface perhaps. Now that I have stabilised the package we can add more function codes.