steveohara / j2mod

Enhanced Modbus library implemented in the Java programming language
Apache License 2.0
263 stars 112 forks source link

Update jserialcom to 2.10.3 #139

Closed AmbroiseS closed 9 months ago

AmbroiseS commented 10 months ago

Hello

  1. I had to clarify ambiguous imports for Record object, I can remove if not wanted

  2. Also I had failing tests :

[ERROR] TestModbusSerialASCIIMasterRead>AbstractTestModbusSerialASCIIMaster.setUpSlave:64 Cannot initialise tests - Port [CNCA0] cannot be opened after [3] attempts - valid ports are: [CNCB0,COM25] [ERROR] TestModbusSerialASCIIMasterWrite>AbstractTestModbusSerialASCIIMaster.setUpSlave:64 Cannot initialise tests - Port [CNCA0] cannot be opened after [3] attempts - valid ports are: [CNCB0,COM25] [ERROR] TestModbusSerialRTUMasterRead>AbstractTestModbusSerialRTUMaster.setUpSlave:56 Cannot initialise tests - Port [CNCA0] cannot be opened after [3] attempts - valid ports are: [CNCB0,COM25] [ERROR] TestModbusSerialRTUMasterWrite>AbstractTestModbusSerialRTUMaster.setUpSlave:56 Cannot initialise tests - Port [CNCA0] cannot be opened after [3] attempts - valid ports are: [CNCB0,COM25] [INFO] [ERROR] Tests run: 113, Failures: 4, Errors: 0, Skipped: 0

Is there something to setup ? I tried setting up CNCA0 with comOcom but then the tests never finished.

Thanks,

steveohara commented 9 months ago

I tested your branch locally and it works fine Not sure why your com0com isn't working, this is how I have mine setup;

image

AmbroiseS commented 8 months ago

Hello,

Thanks,

I noticed that jserialcomm 2.10.3 is not fully mature and seems to crash on spring apps. According to https://github.com/Fazecast/jSerialComm/issues/512

It's probably a good idea to let this one sit a bit, maybe skip it.