ModbusMasterFactory should be in test dir?

[raisercostin]

This is more of a question.

Expected Behavior

I was expecting that com/ghgande/j2mod/modbus/net/ModbusMasterFactory.java to be in src/main/java and be released.

Actual Behavior

• It looks like src/test/java/com/ghgande/j2mod/modbus/net/ModbusMasterFactory.java (was moved from from src/main/java/com/ghgande/j2mod/modbus/net/ModbusMasterFactory.java) in commit fb9c4a7e34e568c212b5fbe026b3e382ed344526
• Is this intentional? ModbusSlaveFactory is in src and is released.

Steps to Reproduce the Problem

1. Check in git commit fb9c4a7e34e568c212b5fbe026b3e382ed344526

[steveohara]

The code in ModbusMasterFactory was only ever intended to be used by the xxxxTest examples, hence most settings are hard-coded (data bits, stop bits, parity, flow control).

It's understandable you might think otherwise though, given that there are a bunch of classes that end in Test that would give the impression that they are in some way Unit Tests. They are not, they are a hangover from the original forked version of j2mod where these were used as command line examples.

I think in a future release, I will make this more obvious by charging their names to end in Example instead.