search

steveohara / j2mod

Enhanced Modbus library implemented in the Java programming language
Apache License 2.0
267 stars 111 forks source link

Added OSGi Support #17

Closed amitjoy closed 6 years ago

amitjoy commented 8 years ago

Closes #15

steveohara commented 8 years ago

Hi Amit - you have a reference warning in your build because you haven't exported something from jSerialComm. The problem will go away if you remove the jSerialComm as an embedded artefact and reference it in the same way as the slf4j. Wouldn't this be the preferred approach?

amitjoy commented 8 years ago

@steveohara Currently jSerialComm library is not provided as an OSGi bundle and hence, it needs to be packaged with j2mod. Your approach would have been the best approach if and only if jSerialComm is packaged as an OSGi bundle.

amitjoy commented 8 years ago

@steveohara I have added OSGi support to jSSC and submitted a PR : https://github.com/Fazecast/jSerialComm/pull/43

If it gets added, I would update this PR accordingly.

feliksik commented 6 years ago

@amitjoy it seems like your upstream jSerialComm PR has been accepted! Are you able to make this PR mergeable now? That'd be great! (If not possible in short term, please let me know!)

Many thanks in advance.

amitjoy commented 6 years ago

@feliksik will do shortly. Thanks for the reminder.