Adds setRetries and setCheckingValidity services into ModbusTCPMaster

steveohara / j2mod

Enhanced Modbus library implemented in the Java programming language

Apache License 2.0

267 stars 111 forks source link

Closed ericauguie closed 7 years ago

ericauguie commented 7 years ago

facade class. Correction in ModbusTCPTransaction: when checkingValidity was false, execute method loops until retry number elapsed.

steveohara commented 7 years ago

Hi Eric, thanks for your contribution. I've pulled it into my development and noticed a couple of things.

The additions to TCPModbusMaster should be to AbstractModbusMaster instead
The logic change doesn't look right to me. Looking at the code it seems to me that the whole retry thing is broken - shouldn't it retry if the response is null as well? This isn't something you have done, it's part of the inherited original codebase so I think we should address that as well

ericauguie commented 7 years ago

Hi Steve, i moved from TCPModbusMaster to AbstractModbusMaster the two setters setRetries and setCheckingValidity

steveohara commented 7 years ago

Hi Eric, I've merged your changes with the exception of the retry edit. I took another look at this and changed the logic to what I think it should be. There is a snapshot with your changes and mine here https://oss.sonatype.org/content/repositories/snapshots/com/ghgande/j2mod/2.3.2-SNAPSHOT/j2mod-2.3.2-20161103.201559-1.jar Could you take a look and make sure its working ok for you.

Steve