stevepolitodesign / rails-authentication-from-scratch

A step-by-step guide on how to build your own authentication system in Rails from scratch.
https://stevepolito.design/blog/rails-authentication-from-scratch/
222 stars 32 forks source link

Fix `current_user` test helper. #85

Closed Tarbetu closed 1 year ago

Tarbetu commented 2 years ago

https://github.com/stevepolitodesign/rails-authentication-from-scratch/blob/9823b3a8682f0132004e0f9a77fb26b197e5be9a/test/test_helper.rb#L17

Hi.

This line seems vague to me. Have you tried to type "elsif" or am I not understanding the purpose of this line? :)

stevepolitodesign commented 2 years ago

That's a great catch! Yes, it should be an elsif. Thank you for pointing this out.

Tarbetu commented 2 years ago

You're welcome! Nice project btw. :)


From: Steve Polito @.> Sent: Friday, February 25, 2022 1:59:50 PM To: stevepolitodesign/rails-authentication-from-scratch @.> Cc: Tarbetu @.>; Author @.> Subject: Re: [stevepolitodesign/rails-authentication-from-scratch] The Vague Line (Issue #85)

That's a great catch! Yes, it should be an elseif. Thank you for pointing this out.

— Reply to this email directly, view it on GitHubhttps://github.com/stevepolitodesign/rails-authentication-from-scratch/issues/85#issuecomment-1050752589, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJTVD6L6QJMWI4SGSRLFIP3U45OKNANCNFSM5PBZT4RA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.Message ID: @.***>

stevepolitodesign commented 1 year ago

Closed by #91