stevermeister / dutch-tax-income-calculator

MIT License
69 stars 5 forks source link

Change Side nav default statues to opened #11

Closed philiphaddad97 closed 1 year ago

philiphaddad97 commented 1 year ago
netlify[bot] commented 1 year ago

Deploy Preview for thetaxnl2 ready!

Name Link
Latest commit 06949b72cd18db79452d5b906c0ae2b3c1af4687
Latest deploy log https://app.netlify.com/sites/thetaxnl2/deploys/64174b91ff77f200074d3335
Deploy Preview https://deploy-preview-11--thetaxnl2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

stevermeister commented 1 year ago

@philiphaddad97 thank you for your contribution!

I only think that it might be better to make it more responsive and for desktops to show on the right always and make it a sidenav for mobile. What do you think?

stevermeister commented 1 year ago

also, I see an issue with mobile now - it hides the main screen that should be first, I suppose

philiphaddad97 commented 1 year ago

Yeah, that's a good point!

I'll see how can I do that. The side nav should be opened by default for desktop and closed for mobile, is it ok?

stevermeister commented 1 year ago

The side nav should be opened by default for desktop and closed for mobile, is it ok

yes, based on previous feedback, I see it as the best UX.

philiphaddad97 commented 1 year ago

@stevermeister Can you check it, please?

stevermeister commented 1 year ago

yes, that's it!