After reloading the home page options "Holiday allowance included", "66 years & older", "30% ruling" always change to Checked status

stevermeister / dutch-tax-income-calculator

MIT License

64 stars 5 forks source link

After reloading the home page options "Holiday allowance included", "66 years & older", "30% ruling" always change to Checked status #9

Closed artur-godunov closed 5 months ago

artur-godunov commented 1 year ago

Possible solution:

In home.component.ts you can change params['allowance'] && this.allowance.setValue(params['allowance']); to if (params['allowance']) { this.allowance.setValue(params['allowance'] === 'true'); } and also change other same code which gets boolean value from url parameters.

stevermeister commented 1 year ago

@artur-godunov good catch! thank you for reporting and suggesting the solution.

Maybe you can make a PR for it?

stevermeister commented 1 year ago

@artur-godunov should be fixed now. one more time thank you for the finding!