search

stevermeister / ngx-cookie-service

Angular (4.2+ ...12) service for cookies. Originally based on the `ng2-cookies` library.
https://www.npmjs.com/package/ngx-cookie-service
MIT License
543 stars 89 forks source link

fix: expose typings for options #218

Closed minijus closed 2 years ago

minijus commented 2 years ago

It would be handy just to import CookieOptions directly instead of re-typing them when using ngx-cookie-service.

pavankjadda commented 2 years ago

@minijus thanks for the PR. We will review and let you know the comments.

pavankjadda commented 2 years ago

@stevermeister I think we can merge this. I wanted to do this for a while, thankfully @minijus did it. Beauty of OSS.

stevermeister commented 2 years ago

thank you @minijus !

@pavankjadda sorry, I'm not very active on a project now, it's difficult to focus for me on something else except news from Ukraine :(

pavankjadda commented 2 years ago

I understand, just wanted to get a quick review. I am sorry for what's going on in Ukraine.