steveruizok / perfect-freehand-dart

Draw perfect freehand lines—in Flutter.
https://steveruizok.github.io/perfect-freehand-dart/
MIT License
242 stars 36 forks source link

Various changes #1

Closed modulovalue closed 3 years ago

modulovalue commented 3 years ago

Hello Steve, Thank you for porting perfect freehand to dart. I was curious what kind of dart and flutter code someone with programming experience, but new to Dart, would write.

You said on twitter that you are open to feedback, so here are some suggestions.

The most important changes in this PR are the following:

Some of the more subjective changes are:

FYI: Flutter supports reading out various information from pressure sensitive input devices such as the Apple Pen on iPads.

Thanks again :)

modulovalue commented 3 years ago

I'm not going to be able to merge his PR [...]

No problem!

steveruizok commented 3 years ago

But seriously, thanks! I've moved over most of your changes into the main branch. With the exception of removing line newlines—I think our eyes might work a bit differently. ;)