search

steves-underwater-paradise / player-animation-rework

Continuation of Kelvin's Better Player Animations.
MIT License
4 stars 0 forks source link

Compatibility with First Person Model #5

Open PPMDJ opened 7 months ago

PPMDJ commented 7 months ago

I think this mod has great potential to be a competitor to Not Enough Animations, but the big thing that is missing is compatibility with FPM! Having both PAR and FPM working seamlessly together would be super immersive.

Steveplays28 commented 7 months ago

Hi PPMDJ, what's not working with First Person Model? I'm using Real Camera and everything's working, so I assumed it'd work the same way with FPM.

Also, I'm planning on adding better compat for Not Enough Animations, since I don't have all animations they have yet, and some NEA features are really cool to use alongside PAR. I made this fork to tidy up some animations, add new ones, and improve compat with full body mods. Some animations were tweaked specifically for full body mods.

PPMDJ commented 7 months ago

Hello! Forgive me as I am new to MC modding and I have to still try to manually install your fork. Generally PAR works great with the port of Kelvin's mod. The big thing that FPM does is raise items held in your hand up to eye level to give that vanilla feel, and gives you the option to adjust it and enable/disable. So when holding a sword the player doesn't hold it to the side but rather angles it up. I think that the PAR idle animation overrides this FPM feature when I tried the other fork.

But aside from that, since PAR has bouncy-er and more lively animations, and a lot more hand movements, there could be some additional tweaking that can be made to improve the first-person experience using first-person rendering mods, giving better visual indicators of what animation your character is performing (sneaking head bobbing, sprinting arm swinging, swimming arm movement, unbalanced flailing on a block ledge (I love that one!), slight head swinging when walking on fence); and perhaps you can set a config for slight animation tweaks for modded first person vs vanilla first person.

I can play around with the mods a bit more end let you know more compatibilities that could be made. Looking forward to your development!

Steveplays28 commented 7 months ago

Ah, I see. The issue where torches/lanterns aren't being held up is something I've been meaning to fix. Thanks for checking out PAR!