search

steves-underwater-paradise / restart-server

Minecraft Fabric mod that adds a restart command to dedicated servers.
https://www.curseforge.com/minecraft/mc-mods/restart-server
GNU Lesser General Public License v2.1
6 stars 2 forks source link

1.18 doesn't work #8

Closed arnokeesman closed 1 year ago

arnokeesman commented 1 year ago

Releases of the mod say it works on 1.18.x and 1.19.x and so does fabric.mod.json but it just doesn't on 1.18. I know the README says you won't backport so it'd just be nice if you could remove the apparent support for 1.18. There's a backport of the dev branch for 1.18.2 on my fork (doesn't work on 1.19), just let me know if you want a PR for it.

Steveplays28 commented 1 year ago

A PR would be amazing! I'll take a look sometime these few weeks. Could you send log files of the error that happens on 1.18 as well?

arnokeesman commented 1 year ago

logs (1.18,2) The problem is that you're using fabric.api.command.v2 to register the command, this doesn't exist for versions below 1.19

Steveplays28 commented 1 year ago

Ahh, makes sense. Thank you.

Steveplays28 commented 1 year ago

Will upload the new build once I'm able to log into Modrinth again. Opened a ticket, it's apparently due to me having so many notifications that the backend bugs, haha. I can confirm everything works though, even wrote a small gametest to verify basic functionality.