steves / node-jira

A nodejs wrapper for the JIRA REST API
378 stars 169 forks source link

WIP ES6 Rewrite and Addition of Unit Tests #124

Closed KanoYugoro closed 8 years ago

KanoYugoro commented 8 years ago

Updated to use ES6 syntax, as well as get off of grub and change to mocha and chai. The tests are not ideal as they do not entirely mock the expected responses, but are approximately equivalent to what existed previously. They are written in ES6 javascript as well now, instead of coffeescript.

All functions requiring callbacks were rewritten using promises, and massive code duplication was reduced wherever found.

A strict eslint version was added to the repository to help enforce coding consistency, as it was sort of all over the place. It reads easier now.

The build agent will fail hard when it tries to build this, as the previously existing version used an entirely different method to run unit tests. Configuring this properly is the last remaining task for this branch.