search

stevesaliman / gradle-cobertura-plugin

Gradle Cobertura Plugin
118 stars 50 forks source link

Gradle 6.x support #165

Closed rpalcolea closed 5 years ago

rpalcolea commented 5 years ago

CoberturaReportsImpl uses internal API that isn't present in Gradle 6.x anymore

https://github.com/stevesaliman/gradle-cobertura-plugin/pull/164/files fixes this

mecorusfc commented 5 years ago

Due to vulnerabilities found in Gradle 5, we are now forced to upgrade to 6 but Cobertura won't work in 6. Here is the error:

I see a pull request. Any hope of getting that done soon? Thanks Mike

stevesaliman commented 5 years ago

I'll look into this as soon as I get some time.

I don't see anything about a Gradle 6.x release, though. Do you mean Gradle 5.6?

mecorusfc commented 5 years ago

The OWASP Dep Check vulnerability in Gradle 5.6.1 and 5.6.2 requires Gradle 6.0 to fix. Right now, only Gradle 6.0-rc1 is available. You have a PR ready to merge to give your plugin 6.0 capability. That’s what I’m asking for.

164: https://github.com/stevesaliman/gradle-cobertura-plugin/pull/164

Thanks,

Michael Corum VP, Technical Architecture Solutions

RGA Reinsurance Company 16600 Swingley Ridge Road Chesterfield, Missouri 6301701706 T 636.736.7066 www.rgare.com

From: "Steven C. Saliman" notifications@github.com Reply-To: stevesaliman/gradle-cobertura-plugin reply@reply.github.com Date: Friday, October 25, 2019 at 8:59 AM To: stevesaliman/gradle-cobertura-plugin gradle-cobertura-plugin@noreply.github.com Cc: "Corum, Michael" mcorum@rgare.com, Comment comment@noreply.github.com Subject: Re: [stevesaliman/gradle-cobertura-plugin] Gradle 6.x support (#165)

External e-mail. Use caution! / Courriel externe. Faites attention!

I'll look into this as soon as I get some time.

I don't see anything about a Gradle 6.x release, though. Do you mean Gradle 5.6?

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_stevesaliman_gradle-2Dcobertura-2Dplugin_issues_165-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DABNDTFIEGHS3DKOO2NBUPPDQQL3UHA5CNFSM4I7RQGMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECIODQA-23issuecomment-2D546365888&d=DwMCaQ&c=5uPv0lijNz76uSeaN5P0Zw&r=rh3Qrw7azSI9xkZZ-a8EEw&m=gxfh5aJiocPMPMi6lR6Zg8wrunR7c7zGklntkluEpTY&s=FqHVn96dHyA4tIRVKD81ZE3oeqUUgK8mG-9iB6d8NbI&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABNDTFKRQWRU2WQVVR3RHRDQQL3UHANCNFSM4I7RQGMA&d=DwMCaQ&c=5uPv0lijNz76uSeaN5P0Zw&r=rh3Qrw7azSI9xkZZ-a8EEw&m=gxfh5aJiocPMPMi6lR6Zg8wrunR7c7zGklntkluEpTY&s=QreuyOyc53lA0L52KEhgDvoetOYgNaOyYjVi6RSzD7s&e=.

stevesaliman commented 5 years ago

The Gradle 6.0 release candidate wasn't available when this issue was first reported, and I didn't see it on any roadmaps at that time either, so this just didn't seem like a very high priority - especially since it was a breaking change. It seemed more like a future proofing kind of thing. They've only just last week released a 6.0 release candidate.

There has also been some chatter in recent weeks of a Cobertura release to solve some long standing issues with it, and I've been waiting to see if that was going to materialize.

I understand that there is a pull request ready to go that could be easily merged, but you also mentioned OWASP, so I suspect that security is important to you. Now what kind of developer would I be if I just merged pull requests without vetting the code first? :smiley:

Steve

eyalroth commented 5 years ago

@stevesaliman I don't know how long it'll take for Gradle 6 to officially get released, but it does include some major improvements which may encourage people to upgrade. One of the more noteworthy improvements for me is the update to Scala's compilation (via zinc).

rpalcolea commented 5 years ago

agree with @eyalroth , also I think we as plugin authors should be more proactive on supporting new versions as soon as RCs come out so people can upgrade right away

mecorusfc commented 5 years ago

Is your plan to wait for the Cobertura release? I ask because as 6.0 candidates come out, I have to report back to the Gradle team that I can’t test until we can get working plugins (yours isn’t the only one but it is the most important for my work). Thoughts?

Michael Corum VP, Technical Architecture Solutions

RGA Reinsurance Company 16600 Swingley Ridge Road Chesterfield, Missouri 6301701706 T 636.736.7066 www.rgare.com

From: "Steven C. Saliman" notifications@github.com Reply-To: stevesaliman/gradle-cobertura-plugin reply@reply.github.com Date: Friday, October 25, 2019 at 10:49 AM To: stevesaliman/gradle-cobertura-plugin gradle-cobertura-plugin@noreply.github.com Cc: "Corum, Michael" mcorum@rgare.com, Comment comment@noreply.github.com Subject: Re: [stevesaliman/gradle-cobertura-plugin] Gradle 6.x support (#165)

External e-mail. Use caution! / Courriel externe. Faites attention!

The Gradle 6.0 release candidate wasn't available when this issue was first reported, and I didn't see it on any roadmaps at that time either, so this just didn't seem like a very high priority - especially since it was a breaking change. It seemed more like a future proofing kind of thing. They've only just last week released a 6.0 release candidate.

There has also been some chatter in recent weeks of a Cobertura release to solve some long standing issues with it, and I've been waiting to see if that was going to materialize.

I understand that there is a pull request ready to go that could be easily merged, but you also mentioned OWASP, so I suspect that security is important to you. Now what kind of developer would I be if I just merged pull requests without vetting the code first? 😃

Steve

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_stevesaliman_gradle-2Dcobertura-2Dplugin_issues_165-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DABNDTFONLRMQTH6BD2GLMFDQQMIQVA5CNFSM4I7RQGMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECIYOEY-23issuecomment-2D546408211&d=DwMFaQ&c=5uPv0lijNz76uSeaN5P0Zw&r=rh3Qrw7azSI9xkZZ-a8EEw&m=DasgQobUlnET-iF36le7B-WCixZj7hbnT9fssKEaGo4&s=A9hAReSpiIrNsTB-gB5-P8GSNgtDEAzu8aYky3jVzQo&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABNDTFP6Z3XSM2JEBNSWQXLQQMIQVANCNFSM4I7RQGMA&d=DwMFaQ&c=5uPv0lijNz76uSeaN5P0Zw&r=rh3Qrw7azSI9xkZZ-a8EEw&m=DasgQobUlnET-iF36le7B-WCixZj7hbnT9fssKEaGo4&s=6JzZyaPmdsgBjdhwADqqj-RcEBO7c5ymOVW0aP1qmoY&e=.

stevesaliman commented 5 years ago

I'm not planning on waiting for an official release. I just need some free time, which has been frustratingly hard to get lately due to other commitments. I'll try to take a look at it this weekend, but next weekend is looking more likely.

I apologize for the inconvenience,

Steve

stevesaliman commented 5 years ago

I found some time this weekend, and was able to release version 3.0.0 of the plugin, which supports Gradle 6. This is a breaking release for really old JVMs and Gradles; the plugin now only works with Java 8+ and Gradle 5.1+, but I doubt that will cause anyone any issues.

Thank you all for your patience while I got this release out.

mecorusfc commented 5 years ago

I switched to 3.0.0 and Gradle 6.0 and tried to run the wrapper and got this:

An exception occurred applying plugin request [id: 'net.saliman.cobertura', version: '3.0.0']

Failed to apply plugin [id 'net.saliman.cobertura'] Could not create task of type 'GenerateReportTask'.

I think this is the same error I was getting before. Are other changes needed to my build.gradle?

Michael Corum VP, Technical Architecture Solutions

RGA Reinsurance Company 16600 Swingley Ridge Road Chesterfield, Missouri 6301701706 T 636.736.7066 www.rgare.com

From: "Steven C. Saliman" notifications@github.com Reply-To: stevesaliman/gradle-cobertura-plugin reply@reply.github.com Date: Sunday, November 10, 2019 at 3:15 PM To: stevesaliman/gradle-cobertura-plugin gradle-cobertura-plugin@noreply.github.com Cc: "Corum, Michael" mcorum@rgare.com, Comment comment@noreply.github.com Subject: Re: [stevesaliman/gradle-cobertura-plugin] Gradle 6.x support (#165)

External e-mail. Use caution! / Courriel externe. Faites attention!

I found some time this weekend, and was able to release version 3.0.0 of the plugin, which supports Gradle 6. This is a breaking release for really old JVMs and Gradles; the plugin now only works with Java 8+ and Gradle 5.1+, but I doubt that will cause anyone any issues.

Thank you all for your patience while I got this release out.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_stevesaliman_gradle-2Dcobertura-2Dplugin_issues_165-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DABNDTFOCAV3CVATDAOSWLPLQTB2VTA5CNFSM4I7RQGMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDVG7AI-23issuecomment-2D552234881&d=DwMCaQ&c=5uPv0lijNz76uSeaN5P0Zw&r=rh3Qrw7azSI9xkZZ-a8EEw&m=eFGL054Me6dXz8fu7SMJoh9DC3pXJJCs-H9_JbD_gl8&s=0QAfKqRDmPyfB6acaN302239Elui_FEAMeUNhRBDIMI&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABNDTFNA4PZPBFGYU4ZPWZTQTB2VTANCNFSM4I7RQGMA&d=DwMCaQ&c=5uPv0lijNz76uSeaN5P0Zw&r=rh3Qrw7azSI9xkZZ-a8EEw&m=eFGL054Me6dXz8fu7SMJoh9DC3pXJJCs-H9_JbD_gl8&s=aN8MyDxF9CiA13ajrS5x0KHb_GsEvwaFOHiiieoaQ7M&e=.

mecorusfc commented 5 years ago

Maybe I’m too early. I can’t find 3.0.0 on mvnrepository yet so maybe it isn’t published. Thanks for merging the PR. Let us know when it is published.

Thanks,

Michael Corum VP, Technical Architecture Solutions

RGA Reinsurance Company 16600 Swingley Ridge Road Chesterfield, Missouri 6301701706 T 636.736.7066 www.rgare.com

From: "Corum, Michael" mcorum@rgare.com Date: Sunday, November 10, 2019 at 6:12 PM To: stevesaliman/gradle-cobertura-plugin reply@reply.github.com, stevesaliman/gradle-cobertura-plugin gradle-cobertura-plugin@noreply.github.com Cc: Comment comment@noreply.github.com Subject: Re: [stevesaliman/gradle-cobertura-plugin] Gradle 6.x support (#165)

I switched to 3.0.0 and Gradle 6.0 and tried to run the wrapper and got this:

An exception occurred applying plugin request [id: 'net.saliman.cobertura', version: '3.0.0']

Failed to apply plugin [id 'net.saliman.cobertura'] Could not create task of type 'GenerateReportTask'.

I think this is the same error I was getting before. Are other changes needed to my build.gradle?

Michael Corum VP, Technical Architecture Solutions

RGA Reinsurance Company 16600 Swingley Ridge Road Chesterfield, Missouri 6301701706 T 636.736.7066 www.rgare.com

From: "Steven C. Saliman" notifications@github.com Reply-To: stevesaliman/gradle-cobertura-plugin reply@reply.github.com Date: Sunday, November 10, 2019 at 3:15 PM To: stevesaliman/gradle-cobertura-plugin gradle-cobertura-plugin@noreply.github.com Cc: "Corum, Michael" mcorum@rgare.com, Comment comment@noreply.github.com Subject: Re: [stevesaliman/gradle-cobertura-plugin] Gradle 6.x support (#165)

External e-mail. Use caution! / Courriel externe. Faites attention!

I found some time this weekend, and was able to release version 3.0.0 of the plugin, which supports Gradle 6. This is a breaking release for really old JVMs and Gradles; the plugin now only works with Java 8+ and Gradle 5.1+, but I doubt that will cause anyone any issues.

Thank you all for your patience while I got this release out.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_stevesaliman_gradle-2Dcobertura-2Dplugin_issues_165-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DABNDTFOCAV3CVATDAOSWLPLQTB2VTA5CNFSM4I7RQGMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDVG7AI-23issuecomment-2D552234881&d=DwMCaQ&c=5uPv0lijNz76uSeaN5P0Zw&r=rh3Qrw7azSI9xkZZ-a8EEw&m=eFGL054Me6dXz8fu7SMJoh9DC3pXJJCs-H9_JbD_gl8&s=0QAfKqRDmPyfB6acaN302239Elui_FEAMeUNhRBDIMI&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABNDTFNA4PZPBFGYU4ZPWZTQTB2VTANCNFSM4I7RQGMA&d=DwMCaQ&c=5uPv0lijNz76uSeaN5P0Zw&r=rh3Qrw7azSI9xkZZ-a8EEw&m=eFGL054Me6dXz8fu7SMJoh9DC3pXJJCs-H9_JbD_gl8&s=aN8MyDxF9CiA13ajrS5x0KHb_GsEvwaFOHiiieoaQ7M&e=.

stevesaliman commented 5 years ago

Strange - It should have been there. Sometimes it takes a couple of hours to propagate. It is there now, and I just checked it against one of my projects using Gradle 6 and the 3.0.0 version of the plugin. It worked as I expected on my end.

mecorusfc commented 5 years ago

Same error this morning and it’s still not on mvnrepository. Can you verify that I’m hitting the right page in mvnrepository?

https://mvnrepository.com/artifact/net.saliman/gradle-cobertura-plugin

id 'net.saliman.cobertura' version '3.0.0'

Is there a different page or dependency coordinate I should try?

Michael Corum VP, Technical Architecture Solutions

RGA Reinsurance Company 16600 Swingley Ridge Road Chesterfield, Missouri 6301701706 T 636.736.7066 www.rgare.com

From: "Steven C. Saliman" notifications@github.com Reply-To: stevesaliman/gradle-cobertura-plugin reply@reply.github.com Date: Sunday, November 10, 2019 at 9:05 PM To: stevesaliman/gradle-cobertura-plugin gradle-cobertura-plugin@noreply.github.com Cc: "Corum, Michael" mcorum@rgare.com, Comment comment@noreply.github.com Subject: Re: [stevesaliman/gradle-cobertura-plugin] Gradle 6.x support (#165)

External e-mail. Use caution! / Courriel externe. Faites attention!

Strange - It should have been there. Sometimes it takes a couple of hours to propagate. It is there now, and I just checked it against one of my projects using Gradle 6 and the 3.0.0 version of the plugin. It worked as I expected on my end.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_stevesaliman_gradle-2Dcobertura-2Dplugin_issues_165-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DABNDTFMQI3AQN5XWCNVILSDQTDDW5A5CNFSM4I7RQGMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDVQXXA-23issuecomment-2D552274908&d=DwMCaQ&c=5uPv0lijNz76uSeaN5P0Zw&r=rh3Qrw7azSI9xkZZ-a8EEw&m=-5QMikQdu-B572bTQk2Igdc1VfbZyjox74JZcJ0PbXw&s=5OrFWf5LRKzG3RxLIyTachgTHGGkFmz5ueDGhQjnnRA&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABNDTFKOVDJ52DS3DFQCH53QTDDW5ANCNFSM4I7RQGMA&d=DwMCaQ&c=5uPv0lijNz76uSeaN5P0Zw&r=rh3Qrw7azSI9xkZZ-a8EEw&m=-5QMikQdu-B572bTQk2Igdc1VfbZyjox74JZcJ0PbXw&s=K6uXUrTjdIxgrTbov2TqmdKo4WHaH9s_eAuhdWehwsA&e=.

stevesaliman commented 5 years ago

I'm not sure how mvnreporsitory.com populates, but I can see the 3.0.0 version of the plugin on Maven Central, and Gradle's own Plugin Repository. I also pushed it to Bintray (which is supposed to feed jcenter), but that may be our outlier. Bintray sees the right version of the plugin here, but it may not have pushed yet.

For grins, if you change the version of the plugin to something invalid (like 3.1.0), do you get the same error, or a different one? That will at least tell us if the plugin is found but not working, or not found.

mecorusfc commented 5 years ago

Thanks, I figured it out. It’s working now. I had to delete all my caches as it seemed to be insisting on bring in old versions.

Michael Corum VP, Technical Architecture Solutions

RGA Reinsurance Company 16600 Swingley Ridge Road Chesterfield, Missouri 6301701706 T 636.736.7066 www.rgare.com

From: "Steven C. Saliman" notifications@github.com Reply-To: stevesaliman/gradle-cobertura-plugin reply@reply.github.com Date: Monday, November 11, 2019 at 9:09 AM To: stevesaliman/gradle-cobertura-plugin gradle-cobertura-plugin@noreply.github.com Cc: "Corum, Michael" mcorum@rgare.com, Comment comment@noreply.github.com Subject: Re: [stevesaliman/gradle-cobertura-plugin] Gradle 6.x support (#165)

External e-mail. Use caution! / Courriel externe. Faites attention!

I'm not sure how mvnreporsitory.com populates, but I can see the 3.0.0 version of the plugin on Maven Centralhttps://urldefense.proofpoint.com/v2/url?u=https-3A__search.maven.org_artifact_net.saliman_gradle-2Dcobertura-2Dplugin_3.0.0_jar&d=DwMCaQ&c=5uPv0lijNz76uSeaN5P0Zw&r=rh3Qrw7azSI9xkZZ-a8EEw&m=z2Apu5vhFFZC65lYf6CTrmxoCOZwKF4EyEbEiJFER2k&s=lV3ZfGh68TcdaIlgiatz5QPv0KAxIp2u0k1fgK778ss&e=, and Gradle's own Plugin Repositoryhttps://urldefense.proofpoint.com/v2/url?u=https-3A__plugins.gradle.org_plugin_net.saliman.cobertura&d=DwMCaQ&c=5uPv0lijNz76uSeaN5P0Zw&r=rh3Qrw7azSI9xkZZ-a8EEw&m=z2Apu5vhFFZC65lYf6CTrmxoCOZwKF4EyEbEiJFER2k&s=hOm7HuyjgUWuwgTycQ_kHAk4Zon-YzDrBkvWfsO1udA&e=. I also pushed it to Bintray (which is supposed to feed jcenter), but that may be our outlier. Bintray sees the right version of the plugin herehttps://urldefense.proofpoint.com/v2/url?u=https-3A__bintray.com_stevesaliman_maven_gradle-2Dcobertura-2Dplugin&d=DwMCaQ&c=5uPv0lijNz76uSeaN5P0Zw&r=rh3Qrw7azSI9xkZZ-a8EEw&m=z2Apu5vhFFZC65lYf6CTrmxoCOZwKF4EyEbEiJFER2k&s=IbRR2Vh46YfW356XcVA3Hs_kS2qwTH4ZgVfCbahxrgY&e=, but it may not have pushed yet.

For grins, if you change the version of the plugin to something invalid (like 3.1.0), do you get the same error, or a different one? That will at least tell us if the plugin is found but not working, or not found.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_stevesaliman_gradle-2Dcobertura-2Dplugin_issues_165-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DABNDTFNFQADHGVRJHD66PZDQTFYTFA5CNFSM4I7RQGMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDXDSDI-23issuecomment-2D552483085&d=DwMCaQ&c=5uPv0lijNz76uSeaN5P0Zw&r=rh3Qrw7azSI9xkZZ-a8EEw&m=z2Apu5vhFFZC65lYf6CTrmxoCOZwKF4EyEbEiJFER2k&s=9_hWGRAZLDdaTwvQ-D0rkM_Ocp-cfxziKedZYWgEA30&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABNDTFJBEW5DNI4TSWIAXKLQTFYTFANCNFSM4I7RQGMA&d=DwMCaQ&c=5uPv0lijNz76uSeaN5P0Zw&r=rh3Qrw7azSI9xkZZ-a8EEw&m=z2Apu5vhFFZC65lYf6CTrmxoCOZwKF4EyEbEiJFER2k&s=ab0CADzLwtOPq79EcLe1C9SRsgVITsr9pu9LQ9zXrSk&e=.

stevesaliman commented 5 years ago

I'm glad to hear that it is working now. Clearing caches is a good tip for anyone who finds this issue later.

Steve