search

stevesaliman / gradle-properties-plugin

Gradle plugin to simplify loading project properties from external environment specific files
Apache License 2.0
192 stars 28 forks source link

Some fixes and improvements #11

Closed Vampire closed 10 years ago

Vampire commented 10 years ago

This pull request fixes the issues #7, #8, #9 and #10 and makes some more minor improvements

stevesaliman commented 10 years ago

Thank you for the contribution. I like the added configurability of being able to choose the variable name used to control the environment. I'll have more time this evening (in the US) to pull in the code and do a release.

In the meantime, do you happen to have any changes to the unit tests for the code changes?

Vampire commented 10 years ago

To be honest, I bluntly ignored the tests, I even forgot to execute them before pushing. :-(

So no, no coverage for the changes yet.

Cool that you like my changes though. :-)

I'll even have one more in mind I just found before I had to get to the train. But as I didn't start on it yet, you can of course also implement it yourself. g It is implementing Plugin, as I need our properties in the settings.gradle already.

If not, please do not wait for another pull request, version numbers are cheap. :-) Well while thinking about it, I don't really care, as without this I cannot really use it. But thanks anyway for this great plugin, it was exactly what I needed.

Vampire commented 10 years ago

Actually I even broke the unit tests with the last commit. This is now amended and the unit tests succeed again.

stevesaliman commented 10 years ago

I haven't had the time I was hoping for to look at the code. I'm hoping I'll have more time over the weekend, and I can take a closer look at the code and add some unit tests.

Vampire commented 10 years ago

I just amended my committs again and added some unit tests for the changed and added functionality. All my code changes should be covered to 100% now.

Vampire commented 10 years ago

Btw. I also prepared the change for being able to Settings, there is just one issue left, namely this one: http://forums.gradle.org/gradle/topics/applying_a_plugin_by_alias_to_settings_gradle I have no idea yet what might go wrong there.