search

steveseguin / electroncapture

Playback video in a frameless electron app for screen-sharing and window capture
GNU General Public License v3.0
325 stars 37 forks source link

Bump node requirement from 14.0.0 to 14.16.0 #62

Closed timburgess closed 2 years ago

timburgess commented 2 years ago

Electron 12 (at least on Linux) doesn't build with Node v14.0.0. But it builds fine with 14.16.0 on linux. Maybe it's worthwhile also adding a comment in the README.md as well?

npm run build:linux

> VDON.Electron.Capture.App@2.5.0 build:linux
> electron-builder --linux

  • electron-builder  version=22.11.7 os=5.11.0-34-generic
  • loaded configuration  file=package.json ("build" field)
  • writing effective config  file=dist/builder-effective-config.yaml
  • packaging       platform=linux arch=x64 electron=12.1.1 appOutDir=dist/linux-unpacked
  • building        target=AppImage arch=x64 file=dist/ElectronCapture-2.5.0.AppImage
  ⨯ fs.rm is not a function  failedTask=build stackTrace=TypeError: fs.rm is not a function
    at createStageDirPath (/work/electroncapture/node_modules/app-builder-lib/src/targets/targetUtil.ts:32:12)
    at Object.createStageDir (/work/electroncapture/node_modules/app-builder-lib/src/targets/targetUtil.ts:27:29)
    at AppImageTarget.build (/work/electroncapture/node_modules/app-builder-lib/src/targets/AppImageTarget.ts:48:7)
CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.