steveseguin / electroncapture

Playback video in a frameless electron app for screen-sharing and window capture
GNU General Public License v3.0
325 stars 36 forks source link

Dynamic Application name #98

Open katoquro opened 1 month ago

katoquro commented 1 month ago

Hello! My issue is quite similar to https://github.com/steveseguin/electroncapture/issues/3 but for an Application name Currently, all run windows have an application name - Chromium. My system uses the Application name to redirect the audio to sink and it works perfectly. However, I also use Chromium browser so all my tabs still contribute to that sink 😅

Is it possible to change this name with run param or so? Thank you in advance

steveseguin commented 1 month ago

You can try using the title command line argument, as noted below, however I'm not 100% sure this will solve your issue.

Let me know though if not

  .option("t", {
    alias: "title",
    describe: "The default Title for the app Window",
    type: "string",
    default: null
  })

@katoquro

katoquro commented 1 month ago

@steveseguin, thank you for your reply! I already use it but it installs Window Title and not Application Name. The application still has Chromium. It is similar to #3 but different 😁

steveseguin commented 1 month ago

https://github.com/steveseguin/electroncapture/releases/tag/2.18.x

Let me know if this trial build works for you. Windows.

If you dont want windows, what operating system?

katoquro commented 1 month ago

I've build ElectronCapture-2.18.4-x86_64.AppImage for linux and it is still detected as Chromium. If it's hard to implement I already have a workaround: I can use Firefox as my browser during scream and leave Chromium only for ElectronCapture. Thanks for your effort! image

steveseguin commented 1 month ago

This is the change I made yesterday, https://github.com/steveseguin/electroncapture/blob/578f1015d5157c3f9d13d5ed74241e74480f9484/main.js#L163

As that doesn't work, the issue might be more related to electron.js, and how it unbundles the app into chromium and other components for use on Linux. This isn't the case with Windows from what I see.

If you can find a solution online, as this would be an issue with Electron.js in general for other apps as well, I'd be happy to patch things. Perhaps when bundling the app I can rename chromium.exe to something else, but who knows what that might break.

katoquro commented 1 month ago

As it could be an Electron issue I found this one https://github.com/electron/electron/issues/7470.

p.s. I'm pretty sure that isn't just binary name so rename shouldn't help

steveseguin commented 1 month ago

Thank you for finding that. It links to this issue, https://github.com/electron/electron/issues/27581, which is Open and seems to be what you are referring to.

image

Not sure if I can reasonably do much to address this issue myself in the near future, other than poke the currently open issue also.

katoquro commented 1 month ago

Yeah 😄 Thanks. At least we will have this thread for those who are also facing such problem.