search

steveseguin / social_stream

Consolidate your live social messaging streams and much more
http://socialstream.ninja/
GNU General Public License v3.0
644 stars 94 forks source link

Owncast support beyond the demo #174

Open TheTechmage opened 10 months ago

TheTechmage commented 10 months ago

I don't know how possible this is with permissions and such, but it'd be really nice if Social Stream supported more than the owncast demo site (such as self-hosted instances). The common pattern I've seen for self-hosters is to run their instance on a watch subdomain (such as watch.example.com). While it may not be possible to have a tld domain wildcard in the extension, would it be possible to have the filter work in the standalone app? (If not, is there anyway I can build it myself for my own usage?)

steveseguin commented 10 months ago

Up to present, my expectation was a user would modify the manifest.json file, available when using the extension-based version of SocialStream, and change the wildcard from https://watch.owncast.online/* to their own domain.

As per the standalone app, it's still just a preview version, and it probably will be for a few more months; I don't consider it in a ready-state. The goal though was to allow users to host the injection/rules code within a folder locally, so they can modify the file contents on their own that way locally if preferred. It's fairly easy I think to add, necessary I feel regardless, and if you like this idea, I can probably get it out to you shortly.

I might be able to also add some options to the standalone app to specify the site you wish to inject code into, overriding the manifest.json's rules, but this will take more time. It involves adding a UI, etc. I believe this approach is what you are requesting?

Anyways, the socialstream version is currently referencing the manifest.json file found in github, so another possibility could be to submit a pull request with the domain added to that manifest file. So long as its a public site that I can review first, we could have a site working within a few minutes.

steveseguin commented 10 months ago

I've released a version that offers two ways of having Owncast work on a private domain

pre-release; will need more testing

TheTechmage commented 10 months ago

Man, you're fast at this xD I wasn't expecting a turnaround within weeks, let alone days. I like the approach that you've taken here for unknown sites (though I think it would help others if the list was sorted first) and I appreciate allowing the user to override the code/manifest files. It appears that the owncast implementation isn't working for me for some reason, but your changes should allow me to tinker around and get a PR ready (assuming it's not a misconfiguration on my part and something changed in the owncast code).

As per the standalone app, it's still just a preview version, and it probably will be for a few more months; I don't consider it in a ready-state. The goal though was to allow users to host the injection/rules code within a folder locally, so they can modify the file contents on their own that way locally if preferred. It's fairly easy I think to add, necessary I feel regardless, and if you like this idea, I can probably get it out to you shortly.

I agree about it being in beta and not quite ready yet. But as a software engineer, I decided to take that risk and fix any issues that I come across. Using the standalone app is also better for performance as the less applications running at a time (such as a browser filled with tabs), the better.

Thank you so much for creating both Social Stream and VDO Ninja. The tech is awesome and I just gets the job done.