steveseguin / vdo.ninja

VDO.Ninja is a powerful tool that lets you bring remote video feeds into OBS or other studio software via WebRTC.
https://vdo.ninja
Other
2.81k stars 801 forks source link

Bug in language settings #1084

Open brianredbeard opened 1 year ago

brianredbeard commented 1 year ago

I've noticed that some fields do not consistently change their labels during translations. I'm still attempting to isolate the behavior, but here are some examples:

I start in a normal state, with English: image

I change the language to pig latin. Notice that the "mute" button on the first participant was not translated while it was on the second:

image

When changing the language back to English, everything changed back EXCEPT the "mute" button on participant two:

image

Switching to Basque changed most of the text again (to Basque), but not the first mute button and this time it changed the mute button to Japanese and truncated it:

image

Finally, setting language back to English leaves me with the same mislabeled mute button on speaker two, and also the "Add to 2" button on both speakers is still in Basque:

image

steveseguin commented 1 year ago

Thank you for reporting these issues. Much appreciated

steveseguin commented 1 year ago

Tooks longer than I thought, but I think I got it mostly fixed.

Changes on https://vdo.ninja/alpha/ for the time being; I;ll get things into production and on github after some more code review/testing.

image