Open rse opened 2 years ago
VDO.Ninja has the nice "&css" option for injecting a custom CSS style sheet. I use this for VDON-Call (https://github.com/rse/vdon-call/) and it works great. VDO.Ninja also could be running inside an and be controlled from outside. But sometimes I would like to directly modify VDO.Ninja from within JavaScript, without having to use a local copy of VDO.Ninja. Something like a "&js" option would be nice for externally loading a piece of JavaScript which then could "hook" into the processing of VDO.Ninja. So, a variant of the <iframe> API, but directly from within the VDO.Ninja context instead of from outside.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/steveseguin"><img src="https://avatars.githubusercontent.com/u/2575698?v=4" />steveseguin</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>Hey Ralf,</p> <p>Thank you for the request.</p> <p>I've hot-patched the feature into production just now; it loads a specified JS file asynchronously. The passed URL needs to be URL encoded. If you'd need it to load synchronously, I can perhaps do that, but it will cause a delay to page loads.</p> <p>'<a href="https://vdo.ninja/?js=https%3A%2F%2Fvdo.ninja%2Fexamples%2Ftestjs.js">https://vdo.ninja/?js=https%3A%2F%2Fvdo.ninja%2Fexamples%2Ftestjs.js</a>'</p> <p>I can hot patch github if needed, but otherwise I'll include it with the v22 beta release, which I've been working on for a few weeks now. </p> <p>(I'll need to chew on the security considerations of this feature long-term, but I don't see harm in it at the moment)</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/rse"><img src="https://avatars.githubusercontent.com/u/221273?v=4" />rse</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>Great. Thanks for the quick change, Steve. The v22 beta release is just fine, I think. I'll test-drive it soon. Perhaps the first idea is to implement a somewhat smarter variant of &sticky on the device selection page. Let's see whether the JS script injection is strong enough to implement such a feature...</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>
VDO.Ninja has the nice "&css" option for injecting a custom CSS style sheet. I use this for VDON-Call (https://github.com/rse/vdon-call/) and it works great. VDO.Ninja also could be running inside an