search

stevesims / govuk-frederic

https://stevesims.github.io/govuk-frederic/
MIT License
3 stars 1 forks source link

Update table component to support borderless and sizing props #109

Closed stevesims closed 6 years ago

stevesims commented 6 years ago

It's now possible to set a borderless flag on the Table component to make the borders vanish.

Additionally the vertical sizing of cells (padding) can be set by specifying a sizing prop. By default this uses the value of SPACING.SCALE_3 from @govuk-react/constants

codecov[bot] commented 6 years ago

Codecov Report

Merging #109 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #109   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          27     27           
  Lines         215    218    +3     
  Branches       46     46           
=====================================
+ Hits          215    218    +3
Impacted Files Coverage Δ
components/table/src/index.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 66a29c0...1665b84. Read the comment docs.

gavinorland commented 6 years ago

I found out a bit more about this: if either the first-child or the last-child blocks are present, then the first style property outside them is set but cannot be found, regardless of what it is and of whether those blocks are placed before of after the other rules. So, for example, if we move borderBottom to after display then it's found, but display isn't!