search

stevesims / govuk-frederic

https://stevesims.github.io/govuk-frederic/
MIT License
3 stars 1 forks source link

countdown text area default doesn't display countdown #30

Open Loque- opened 6 years ago

Loque- commented 6 years ago

It's a little confusing, could we add the countdown to the component default?

http://localhost:9009/?knob-Children=Back&selectedKind=Forms%2FCountdownTextArea&selectedStory=Component%20default&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel

gavinorland commented 6 years ago

What was the decision on this? Wondering if we can close the issue.

Loque- commented 6 years ago

The issue I had was that I thought it was confusing that by default it does not have a counter - not sure if this is just me or not?

gavinorland commented 6 years ago

Yes, probably not ideal. Steve suggests adding a maxLength={150} to the default story but maybe not to the component's own default props. The reason being that would then just be an arbitrary number. Trouble is I guess that would mean the story did not actually represent the component default. Argh! Perhaps we had better just leave as is unless there is an appropriate default value - or remove the default story.