Closed Loque- closed 6 years ago
Rebased with master to merge earlier changes to package.json file
Merging #35 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #35 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 19 19
Lines 146 146
Branches 16 16
=====================================
Hits 146 146
Impacted Files | Coverage Δ | |
---|---|---|
components/keyline/src/index.js | 100% <ø> (ø) |
:arrow_up: |
components/result-count/src/index.js | 100% <ø> (ø) |
:arrow_up: |
components/distraction-free/src/index.js | 100% <ø> (ø) |
:arrow_up: |
...ponents/compact-table-accordion-group/src/index.js | 100% <ø> (ø) |
:arrow_up: |
components/table-accordion-group/src/index.js | 100% <ø> (ø) |
:arrow_up: |
components/result-count-title/src/index.js | 100% <ø> (ø) |
:arrow_up: |
components/remove-button/src/index.js | 100% <ø> (ø) |
:arrow_up: |
components/title-result-count/src/index.js | 100% <ø> (ø) |
:arrow_up: |
components/count/src/index.js | 100% <ø> (ø) |
:arrow_up: |
components/arrow-left/src/index.js | 100% <ø> (ø) |
:arrow_up: |
... and 3 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6bfa137...4098097. Read the comment docs.
Githubs rather harsh version of my actions are untrue! I applied the changes : D
Bar the test for the NTA constant... which I tried but it hits this as it must be doing something with the string;
heh - emotion munging that string is unfortunate
i guess we could do something like this:
expect(wrapper).toHaveStyleRule('font-family', NTA_LIGHT.replace(/\s/g, '');
This PR resolves two issues;
Whilst doing this, I noticed that the components should be using @govuk-react/constants a lot more, something for another ticket/PR.