search

stevesims / govuk-frederic

https://stevesims.github.io/govuk-frederic/
MIT License
3 stars 1 forks source link

Add and use govuk-react's withWhitespace HOC #44

Closed stevesims closed 6 years ago

stevesims commented 6 years ago

Many/most components within govuk-frederic should use withWhitespace - for example the Table component should automatically get whitespace below it

gavinorland commented 6 years ago

What's the preferred marginBottom to be sent in? For example:

export default withWhiteSpace({ marginBottom: 3 })(Table);

If you have a list of those that should have white space and any variance between them I'll be happy to add this.

stevesims commented 6 years ago

to be honest, i don't know what the preferred value should be - for reference check to see what's typically used in govuk-react.

As for which components should get whitespace - it looks to me like Table, CompactTableAccordionGroup, TableAccordionGroup, CounterBar and Keyline

gavinorland commented 6 years ago

Right, I'll assign this to myself and compare with govuk-react... :thumbsup:

gavinorland commented 6 years ago

This is addressed by https://github.com/stevesims/govuk-frederic/pull/48 but there is not always an equivalent component in govuk-react - just let me know if margins should be different when you see these components in the sec-env.

gavinorland commented 6 years ago

Resolved by https://github.com/stevesims/govuk-frederic/pull/48