search

stevesims / govuk-frederic

https://stevesims.github.io/govuk-frederic/
MIT License
3 stars 1 forks source link

Improve display of Storybook as with govuk-react #81

Closed gavinorland closed 6 years ago

gavinorland commented 6 years ago

Equivalent to https://github.com/UKHomeOffice/govuk-react/pull/374

codecov[bot] commented 6 years ago

Codecov Report

Merging #81 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #81   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          27     27           
  Lines         215    215           
  Branches       46     46           
=====================================
  Hits          215    215

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f8c070d...adc1646. Read the comment docs.

gavinorland commented 6 years ago

We'll hold off on this and I'll implement Toby's neat solution which uses withDocs but hides the component display!

stevesims commented 6 years ago

@gavinorland this looks really close - just a small push to get it over the line implementing the changes to avoid the use of dangerouslySetInnerHTML - any chance of updating this so we can merge it in?

gavinorland commented 6 years ago

@stevesims Yep, I'll do this soon and we can get it in.