search

stevesouders / spriteme

Automatically exported from code.google.com/p/spriteme
11 stars 8 forks source link

Only sprites if elements are visible #50

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Go to
http://svg-edit.googlecode.com/svn-history/r646/trunk/editor/svg-editor.html
2. Click the SpriteMe bookmarklet.

What is the expected output? What do you see instead?
SpriteMe should offer to sprite the align buttons.  But because these
elements are not visible, SpriteMe does not suggest that.

However, if you do the following:

1. Go to
http://svg-edit.googlecode.com/svn-history/r646/trunk/editor/svg-editor.html
2. Draw two ellipses
3. Drag-Select both ellipse
4. Click the SpriteMe bookmarklet

SpriteMe will offer to generate a sprite for the align images.

SpriteMe should analyze all images, even if the images are not displayed.

Original issue reported on code.google.com by codedr...@gmail.com on 15 Sep 2009 at 1:30

GoogleCodeExporter commented 9 years ago 
+1 on this for me. In my case it is a drop down menu with many images (icons) 
that
would work well as sprites.

Original comment by damianha...@gmail.com on 16 Sep 2009 at 9:53

GoogleCodeExporter commented 9 years ago 
I see now why this happens: 

http://code.google.com/p/spriteme/source/browse/trunk/spriteme.js#1459
http://code.google.com/p/spriteme/source/browse/trunk/spriteme.js#1367

Seems like you're using the element's width/height to determine the image 
dimensions,
which makes sense.

Original comment by codedr...@gmail.com on 16 Sep 2009 at 6:48

GoogleCodeExporter commented 9 years ago 
I'm assuming this is the same issue as dynamic css images (hover for example) 
not showing?  IMHO, this is critical to being useful.

Original comment by jbrown...@gmail.com on 12 Jul 2010 at 5:45