Downloading and uncompressing from scratch is slower than needed

stevespringett / nist-data-mirror

A simple Java command-line utility to mirror the CVE JSON data from NIST.

Apache License 2.0

206 stars 93 forks source link

Downloading and uncompressing from scratch is slower than needed #116

Closed trandersen-ufst closed 2 years ago

trandersen-ufst commented 2 years ago

Looked at this as part of investigating how to create an offline in-house procedure. Found this to be very slow, and discovered that the downloading and uncompressing is not buffered, and the byte[]->Hex string is repeatedly invoking String.format.

Fixing this caused the run time on my machine went from 53 minutes down to 44 seconds.

stevespringett commented 2 years ago

Big thanks for the PR.