search

stevespringett / nist-data-mirror

A simple Java command-line utility to mirror the CVE JSON data from NIST.
Apache License 2.0
206 stars 93 forks source link

Helm chart #27

Closed ujjwalpatil closed 5 years ago

ujjwalpatil commented 5 years ago

Created Helm chart for deploying NIST mirror as service in k8s. Thanks for the help @rljohnsn

stevespringett commented 5 years ago

Thanks for the PR. Could you modify the README so that it separates out the normal usage from the K8 usage. This is not a K8 project, it's actually just a java utility that can be run from the command line with an optional container runtime. Having k8 on top of that is great, but I don't want to confuse users about the goals of the project.

I would recommend creating a directory for k8 and putting the relevant readme and configuration in there

ujjwalpatil commented 5 years ago

Steve, as suggested, I have moved all charts files to k8s top directory. Please let me know if that works.

rljohnsn commented 5 years ago

/bump @stevespringett @ujjwalpatil

stevespringett commented 5 years ago

Thanks for the reminder and PR.