search

stevespringett / nist-data-mirror

A simple Java command-line utility to mirror the CVE JSON data from NIST.
Apache License 2.0
206 stars 93 forks source link

adding the gradle wrapper plus a minor readme update #5

Closed spyhunter99 closed 7 years ago

stevespringett commented 7 years ago

The build wrappers should not be necessary. We're not trying to ensure that it builds on every possible environment. That's not the goal of this project. It's also concerning that the build wrappers contain much more code than the actual NIST mirroring class.

spyhunter99 commented 7 years ago

well i didn't have it installed globally and thought it would be helpful. Anyhow, very useful library

nickspacek commented 7 years ago

I would just put it out there that the Gradle folks recommendation is that projects include the wrapper:

https://docs.gradle.org/current/userguide/gradle_wrapper.html

The Wrapper is something you should check into version control. By distributing the Wrapper with your project, anyone can work with it without needing to install Gradle beforehand. Even better, users of the build are guaranteed to use the version of Gradle that the build was designed to work with. Of course, this is also great for continuous integration servers (i.e. servers that regularly build your project) as it requires no configuration on the server.

But I can respect the points you are making.