search

stevespringett / nist-data-mirror

A simple Java command-line utility to mirror the CVE JSON data from NIST.
Apache License 2.0
206 stars 93 forks source link

Introduce a logger #66

Open artem-smotrakov opened 4 years ago

artem-smotrakov commented 4 years ago

I see that the project uses System.out to print out messages, for example:

https://github.com/stevespringett/nist-data-mirror/blob/8f1faec3985fd17fd8d2b97aa66b4690cd542ada/src/main/java/us/springett/nistdatamirror/NistDataMirror.java#L116

As a result, an application that uses the library doesn't have much control over this messages. It would be better to use a logger. If this improvement sounds good, I can open a pull request that introduces log4j. Please let me know what you think.

stevespringett commented 4 years ago

Yes, that sounds like a good improvement.