Issue #62 - Allow http proxy values to be supplied through values.yaml

stevespringett / nist-data-mirror

A simple Java command-line utility to mirror the CVE JSON data from NIST.

Apache License 2.0

206 stars 93 forks source link

Issue #62 - Allow http proxy values to be supplied through values.yaml #71

Closed mookkiah closed 3 years ago

mookkiah commented 3 years ago

It is better to leave the JVM options to be configurable so that the end user can configure more options not just proxy. Also providing env configurable in values.yaml opens up opportunities for the users. Updated the documentation to reflect the changes Tested the image and helm chart in Kubernetes.

Note: Readme markdowns are formatted by the IDE. I touched up to not to have so many.

mookkiah commented 3 years ago

@stevespringett Please review and give your comments.

mookkiah commented 3 years ago

@roelofjansen Please review. I see Ujjwal Patil as maintainer for the chart but I couldnt find the username matching the name.

mookkiah commented 3 years ago

@stevespringett Please let me know if there is any reason for keeping this PR open. I am happy to help and delete my fork.

stevespringett commented 3 years ago

Delayed due to moving. Thanks for the PR. Much appreciated.