search

stevespringett / threatmodel-sdk

A Java library for parsing and programmatically using threat models
79 stars 24 forks source link

Added support for InputStream as input. #9

Closed sswargam closed 4 years ago

sswargam commented 7 years ago

The iParser interface has changed to support InputStream. However, the ThreatModelFactory remains intact with added support for InputStream.

stevespringett commented 7 years ago

Thanks for the PR, however, these changes break the existing API and will prevent applications that use this library from upgrading to a newer version without code changes. The library is currently being used for at least one commercial application that I'm aware of and many private implementations specific to various orgs. Requiring code changes on their part is a non-starter.

sswargam commented 7 years ago

The applications that use the API would only invoke the ThreatModelFactory isn't it? We could leave the iParser method and add a new method for the InputStream. Let me know if you would like that.

sswargam commented 4 years ago

Added support for Medical Device template