search

steveszc / ember-cli-memory-leak-detector

Automatic memory leak detection for ember apps
https://www.npmjs.com/package/ember-cli-memory-leak-detector
MIT License
38 stars 5 forks source link

Improve handling of memory leak detection results #4

Closed steveszc closed 4 years ago

steveszc commented 4 years ago

Right now the results of the detection are just logged as part of the output of ember test. This gives us no way to fail the test suite itself or influence the pass/fail result of CI. We may want to treat this similarly to code coverage tools where the results are sent to some external service that can be integrated separately into CI. We may also consider how we could support failing of the test suite if a leak is detected (ideally this would be a configurable option).

steveszc commented 4 years ago

Addressed in 0d3d5c7547342a867f4f7affbb14a1898cf17f73 by adding an error config flag. By default detected memory leaks will produce a global test failure. enabled: false will cause a CI console warning but no error.