search

steveway / papagayo-ng

Papagayo is a lip-syncing program designed to help you line up phonemes (mouth shapes) with the actual recorded sound of actors speaking. Papagayo makes it easy to lip sync animated characters by making the process very simple - just type in the words being spoken (or copy/paste them from the animation's script), then drag the words on top of the sound's waveform until they line up with the proper sounds.
http://steveway.github.io/papagayo-ng/
18 stars 3 forks source link

Windows Uninstaller only sees most recent install #33

Closed Hunanbean closed 1 year ago

Hunanbean commented 2 years ago

Windows uninstaller, "programs and features", only lists the latest installation, even though i have several located in different folders.

steveway commented 2 years ago

Ah yes, we are always writing to the same registry entry with the Installer. https://github.com/steveway/papagayo-ng/blob/master/papagayo-ng.nsi I guess we need to modify our script to also insert the version information. The usage is explained here kinda: https://nsis.sourceforge.io/mediawiki/index.php?title=Add_uninstall_information_to_Add/Remove_Programs&oldid=25114 Since during the packaging with PyInstaller we add the version to the .exe file we can get the version from that. Apparently NSIS has the command getdllversion for that: https://nsis.sourceforge.io/Docs/Chapter5.html#ppgetdllversion This should give each version its own entry for the programs and features, but it will still give problems when you install the same version multiple times. So I guess we would also need to check if that registry key exists for that version already during install and stop the installation then.

Hunanbean commented 2 years ago

Perhaps when reinstalling the same version it could trigger a notification and allow overwrite.

Hunanbean commented 2 years ago

Apologies for the long absence. I am now entirely on Linux, so i would not be able to tell if this issue is resolved.