search

stevezhengshiqi / one-key-cpufriend

Generate customized CPUFriendDataProvider.kext for dynamic macOS CPU power management
337 stars 47 forks source link

[BUG]: generated CPUFriendDataProvider.kexts for each performance setting are all the exact same #16

Closed LeeBinder closed 4 years ago

LeeBinder commented 4 years ago

I just created a CPUFriendDataProvider.kext for MacBookPro15,4 for each performance setting (always moved generated CPUFriendDataProvider.kext away from Desktop into a newly created folder whose name matches the chosen performance setting), extracted the cf-frequency-data string from each Info.plist inside each kext, saved as txt files with names matching the performance, and cross-compared all 4 with Beyond Compare text compare mode. Result: THEY ARE ALL THE EXACT SAME, or in other words, the script does NOT work (at least not for model 15,4).

CPUFriendDataProvider for MacBookPro15,4 with stevezhengshiqi's one-key-cpufriend.zip

LeeBinder commented 4 years ago

oh, it might be because I accidentally already had another mod of CPUFriendDataProvider installed ...

I'll re-test ASAP with a clean vanilla config (might not be tomorrow).

LeeBinder commented 4 years ago

@stevezhengshiqi I just re-checked it on a vanilla OS: the script is NOT working, at least not for MacBookPro15,4 - producing the exact same strings from [(1) Max Power Saving] .. (2)..(3) .. (4) Performance]. I always chose (2) 800mhz.

I don't have any more time to invest into this and can't debug if the bug is in your part of the script, or in the downloaded part.

Any idea?

stevezhengshiqi commented 4 years ago

I didn't notice that. Thank you so much for reporting this issue.

LeeBinder commented 4 years ago

Great Steve that you found the problematic line and fixed it so quickly! I can confirm the strings now look different for each performance for MBP15,4:

(1) Max Power Saving: 77 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 44

(2) Balance Power (Default): 77 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 43

(3) Balance performance: 77 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 42

(4) Performance: 77 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41

:+1:

LeeBinder commented 4 years ago

@stevezhengshiqi sorry, but same thing with MacBookAir8,2 - all strings are the same .. :(

stevezhengshiqi commented 4 years ago

@LeeBinder Hi, I am pretty sure that the script is effective on Mac-226CB3C6A851A671(MBA8,2). Could you have a recheck on that?

LeeBinder commented 4 years ago

@stevezhengshiqi : this must most likely be a bug in the most recent Beyond Compare app which shows me the expected diffs in the same files in Catalina but not in Mojave - sorry about the false alert!

MacBookAir8,2 Mac-226CB3C6A851A671 CPUFriendDataProvider

via stevezhengshiqi's one-key-cpufriend:

in Catalina with kexts via Clover/kexts/Other

(1) Max Power Saving: 0A 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 44

(2) Balance Power (Default): 0A 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 43

(3) Balance performance: 0A 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 42

(4) Performance: 0A 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41 41