stevezhengshiqi / one-key-cpufriend

Generate customized CPUFriendDataProvider.kext for dynamic macOS CPU power management
337 stars 47 forks source link

More appropriate reminder in the end #27

Closed PMheart closed 3 years ago

PMheart commented 3 years ago

Hello again,

I am not sure whether it is a good idea to make another comment in the previous issue, as this is totally another story. The point is that you have already put requirements for OpenCore in README, but you ignored the same thing in script like this. Please fix.

Also, now I am thinking of whether this repo can be merged into CPUFriend upstream, probably more discussion is required. If this sounds good, I guess we need to fix a bunch of codestyle issues. For example, you have inconsistent style of function declaration at a glance.

Thanks!