pins don't get set back to default under brewbuild

stevieb9 / rpi-wiringpi

Perl interface to Raspberry Pi's board, GPIO and various sensors and ICs

7 stars 1 forks source link

pins don't get set back to default under brewbuild #41

Closed stevieb9 closed 7 years ago

stevieb9 commented 7 years ago

I wonder if it's due to the env var not being available? It's not just brewbuild... bbdispatch too.

Perhaps we need to make the pin registrations disk-based.

stevieb9 commented 7 years ago

So, this is caused by brewbuild using the Dispatch module, which if BB_RPI_LCD set, creates an LCD object immediately which throws off all of the pin status checks.

Need to think about this. Somehow skip/remove the LCD pins from testing/being reset if it's BB running the tests, and BB_RPI_LCD is set?

Perhaps manually registering the LCD pins in Dispatch so that when the tests start, the already-changed pin states will be reflected in test results/reset? Then we'd have to either have a DESTROY to un-register/unset them after a run.

stevieb9 commented 7 years ago

Perhaps:

put the LCD init code in Dispatch into a subroutine, and load it up only when needed (after all test output is returned, and only if we're actually in dispatch code)
change the init to get the LCD from a $pi object instead, so that all pin registration/deregister is done automatically (force a call to RPi::WiringPi::Util::cleanup()?

stevieb9 commented 7 years ago

After update to Dispatch, things now work if the env var is set, but we're not using the dispatcher in auto mode. Will have to take corrective action after testing that functionality.