steviebarrett / faclair-manuscripts-1

A repository for the Faclair na Gàidhlig manuscript transcription project
0 stars 0 forks source link

Meanma not displaying information in RHP when entire word/multiple words are supplied #1026

Open mnimheachair opened 3 years ago

mnimheachair commented 3 years ago

When an editor supplies an entire word or a series of words the information showing the extent of supplied text is not showing up in the RHP on Meanma

e.g. T39, f8v.8 <supplied resp="Greene1944"><w id="d1e20306" lemma="do" lemmaRef="http://www.dil.ie/17096" pos="prepositional_pronoun">dhi</w></supplied>

RHP shows: text supplied by editor – [undefined] (Greene1944)

RHP should display: text supplied by editor – [dhi] (Greene1944)

e.g. T21, p.176.b6 ``

Neill
                        <w id="d1e1372" lemma="mac" lemmaRef="http://www.dil.ie/31166" pos="noun">vic</w>
                    </supplied>``

RHP shows: text supplied by editor – [undefined] (MMA)

RHP should display: text supplied by editor – [Neill vic] (MMA)

mnimheachair commented 3 years ago

It should be noted that when a character (or characters) are supplied within a word the RHP displays the information fine.

e.g. T29 p.694.15 <w id="d1e2139" lemma="bríathar" lemmaRef="http://www.dil.ie/6796" pos="noun">mbria<supplied resp="Black1973">thar</supplied></w> This displays in the RHP as: text supplied by editor – [thar] (Black1973)

e.g. T30, 3r.19 <w id="d1e6871" lemma="betha" lemmaRef="http://www.dil.ie/5779" pos="noun">m<supplied resp="EPT">b</supplied>e<abbr cert="high">t<g id="d1e6878" ref="g4">h</g> This displays in the RHP as: text supplied by editor – [b] (EPT)

steviebarrett commented 3 years ago

Meanma now displays <supplied> information as per the webtool, including where there are multiple words within the element.

I noticed that the webtool did not display multiple words in the RHS – so clicking on "Neill" in the above displays :

Neill is an anthroponym scribe: Walter MacFarlane has been supplied by an editor (MMA)

Meanma now echoes this functionality. If multiple words are to be clickable at once and displayed as a unit then <supplied>elements will require IDs and we would probably need to think about other implications.

steviebarrett commented 3 years ago

@conmaol will re-examine this