Button broken on alt account, craftscan tab not on profession pane

stevin05 / CraftScan

MIT License

5 stars 2 forks source link

Button broken on alt account, craftscan tab not on profession pane #27

Closed Ammastusx closed 1 month ago

Ammastusx commented 1 month ago

Hi, I configured the addon and it was working. I logged out and exited the game on my alt account and now when I click the button it won't open the craftscan tab. I do get pings still, but I'm unable to see the UI.

https://imgur.com/a/oQoIynN

Though its still connected to my other account.

stevin05 commented 1 month ago

Enable lua errors (/console scriptErrors 1) or install buggrabber/bugsack and paste the full errors here. They will probably happen when you reload or login. There must be some error initializing the page, but no idea where to start looking without the real error.

ZyborgRSA commented 1 month ago

Similar issue for me, button doesn't load at all on relog/reload either. When I change something on main account, it throws error on second account, but still can't open craftscan on it. Error from Bugsack: 17x CraftScan/ChatScanner.lua:173: bad argument #1 to 'pairs' (table expected, got nil) [string "=[C]"]: in function pairs' [string "@CraftScan/ChatScanner.lua"]:173: in functionLoadConfig' [string "@CraftScan/OrderPage.lua"]:1257: in function `OnCrafterListModified' [string "@CraftScan/Utils/Comm.lua"]:283: in function <CraftScan/Utils/Comm.lua:241> [string "@CraftScan/Utils/Comm.lua"]:1204: in function <CraftScan/Utils/Comm.lua:1166> [string "@CraftScan/Utils/Comm.lua"]:1249: in function <CraftScan/Utils/Comm.lua:1243>

Locals: (temporary) = nil (temporary) = "table expected, got nil"

ZyborgRSA commented 1 month ago

If it helps I just deleted the WTF file for Craftscan on the second account and re-synced it, seems fine now

stevin05 commented 1 month ago

I'm guessing this has to do with AA shuffling. The account link code is not properly handling learning a profession while both accounts are online. If you learn a profession, open it, don't touch any CraftScan config items, then toggle anything on the Crafter List to enable/disable scanning for that character, it only sends part of the config and I was able to hit this error.

Does that sound like a possibility? Going to move forward with fixing that as well as adding an upgrade task to clean up any misconfigs caused by this in WTF files. If you ever hit this type of thing again, a reload will likely fix it with this new cleanup task.

ZyborgRSA commented 1 month ago

Very possible, was also jumping between characters quite a lot when I was setting it up. Thanks for taking a look. Appreciate the work! Great addon