search

stevo / colorbox-rails

Make links open in lightbox a breeze
MIT License
77 stars 58 forks source link

Update README, remove .idea directory, change colobox calling method, add gallery-mode by rel attribute. #18

Closed drakmail closed 11 years ago

drakmail commented 11 years ago

Remove .idea directory

Add some more options

Update README

Clean gemspec

Update colorbox creation method (need for attribute work), update README, bump version

tcfunk commented 11 years ago

I have been poking at this project myself. The problem with the change is that any link that is dynamically added won't have color box applied to it without calling the function again manually, where it did before. But it just depends on whether or not that matters.

drakmail commented 11 years ago

Heh, interesting. But groups doesn't work (maybe, I doing something wrong?) if colorbox applied by onclick event. I think, it need different data- attributes for firing colorbox - one for statical (my variant, works with groups), and one for dynamycall (initial variant, works with dynamycally added links).

drakmail commented 11 years ago

In 67336a5 I'm save original behavior and added data-colorbox-static attribute for new behavior (with static links).