search

stewartmcgown / grammarly-api

📚 Unofficial TypeScript client for the Grammarly API
MIT License
208 stars 18 forks source link

Dialect doesn't appear to be an optional param #33

Open jambran opened 2 years ago

jambran commented 2 years ago

Cheers for the excellent work here. Has made interfacing with Grammarly a breeze.

In the README, it indicates that dialect is an optional param to analyze, but I can't seem to get different results when I pass in "american".

Interacting with the web browser, I have no corrections for the word yogurt. But through the API, where it seems the dialect is "british", I get corrections for yogurt to be yoghurt instead.

Any chance I'm doing something wrong with the API? My call looks like this.

results = await premium.analyse(sentence, 5000, "american");
jambran commented 2 years ago

Ah, I think I've got it. It looks like the latest release to npm doesn't include the changes made to handle dialect. I got it to work by installing locally instead of through npm.

stewartmcgown commented 2 years ago

No worries. This is totally unmaintained so glad it's working for you.

On Mon, 9 May 2022, 21:48 Jamie Brandon, @.***> wrote:

Ah, I think I've got it. It looks like the latest release to npm doesn't include the changes made to handle dialect. I got it to work by installing locally instead of through npm.

— Reply to this email directly, view it on GitHub https://github.com/stewartmcgown/grammarly-api/issues/33#issuecomment-1121509244, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIVNFFOQG3BII66FFP4LP3VJFTZZANCNFSM5VOU56YQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>