search

stewartmcgown / uds

📀 Unlimited Google Drive Storage by splitting binary files into base64
GNU Affero General Public License v3.0
4.35k stars 280 forks source link

Implement argparse #70

Closed alanyee closed 5 years ago

alanyee commented 5 years ago

-Implement argparse -Remove unnecessary print calls that cause unnecessary overhead -List comprehensions

sammyhass commented 5 years ago

No need for argparse. Additional dependencies are not required.

stewartmcgown commented 5 years ago

I'm not actually against argparse, might make things easier later on.

chlohe commented 5 years ago

argparse is portable and pretty much standard at this point. +1 for increased maintainability.

On a somewhat unrelated note, verbosity flags for easier debugging?

alanyee commented 5 years ago

@PeterTheHe I can make secondary shorter flags. It is easy to do; I just wanted to keep my changes roughly minimal in case this PR was rejected for some reason.

@SammyHass I would say there is a need for argparse especially since the current help message is not up-to-date, makes adding new flags/features easier, allows the same uds process to do multiple different tasks, and besides, argparse is in the python standard library.

sammyhass commented 5 years ago

Sure, @PeterTheHe and @stewartmcgown are the gods here. Their opinions are more relevant than mine. Sorry guys and sorry @alanyee for being harsh. I will review your code now.

Sorry again

sammyhass commented 5 years ago

Will also start on contribution guidelines at some point so I can't be as much of a dick.