search

stewartpark / Flask-JSGlue

Flask-JSGlue helps hook up your Flask application nicely with the front end.
80 stars 39 forks source link

Fixed Markup import; it is now imported from markupsafe #32

Open italomaia opened 2 years ago

italomaia commented 2 years ago

Importing Markup from jinja2 doesn't work anymore. This fixes the issue. Also took the liberty of sorting imports.

aareman commented 1 year ago

My team has a small flask application that depends on this library. @stewartpark is there any likelyhood of this PR being merged? (last commit on the repo was in 2018, so it looks like it's not being actively maintained.)

I appreciate the hard work you put in to making this very useful package.

corlukantonio commented 1 year ago

I also had one of my demo apps using this package running perfectly fine on Heroku, but since Heroku started requiring a newer stack (Heroku-22), the version of Python (3.7) I was using for the app became deprecated. I then switched to Python version 3.9 and kept getting this error when trying to run the app. Not sure if it was because of the Python version, but either way, I hope this gets seen by the author (@stewartpark) and merged.

willfinnigan commented 9 months ago

JSGlue is a great flask add-on - its a shame to not be able to use it anymore. Would be fantastic to have this pull request approved @stewartpark 😁

aareman commented 9 months ago

@willfinnigan @corlukantonio you can always fork the repo with the pr and install that commit hash instead. That's what we ended up doing.

You can use my companies fork if you like https://github.com/Centers-Health/Flask-JSGlue