search

stewdio / THREE.VRController

Support hand controllers for Oculus, Vive, Windows Mixed Reality, Daydream, GearVR, and more by adding VRController to your existing Three.js-based WebVR project.
https://stewdio.github.io/THREE.VRController/
MIT License
230 stars 33 forks source link

THREE.VRController.onGamepadDisconnect needs to be called when contro… #22

Open lehoangphu opened 5 years ago

lehoangphu commented 5 years ago

…llers are removed.

The flow of the bug goes like this: . When the controller is connected, the gamepad object is saved at this.controller[x] . then when the controller is disconnected, the saved this.controller[x] is still in your array but the object is gone (all null) . then when the controller is reconnected again, it see that both gamepads[x] and this.controller[x] are both non-null so it does not update, then goes on to consume this.controller[x] which is already stale.

This change makes sure that we flush out the this.controllers array correctly.

codefrau commented 5 years ago

This fixes our exact problem. Please merge!

lehoangphu commented 5 years ago

@stewdio , can you merge this one?